feat(ssr): render in Cloud Function, not in build #11459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
changed the title
LeoMcA
force-pushed
the
cloud-function-ssr
branch
2 times, most recently
from
562210f
to
11cb342
Compare
https://mozilla-hub.atlassian.net/browse/MP-1349 inline env at build time into ssr bundle
LeoMcA
force-pushed
the
cloud-function-ssr
branch
from
11cb342
to
d154110
Compare
caugner
reviewed
Jul 12, 2024
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1349)
Problem
Solution
index.htmlfrom buildingindex.json#10953 we've split generating the context for all our pages from the SSR step, and can move the SSR step into the cloud function, rather than happening at build timeHow did you test this change?
Deployed to https://test.developer.allizom.org/en-US/, checked across locales/page types with JS enabled/disabled